Bug 306448
| Summary: | [grid-lanes] Fix grid-lanes-subgrid-002a test to match cross-browser rendering behavior | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brandon <brandonstewart> |
| Component: | CSS | Assignee: | Brandon <brandonstewart> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | koivisto, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Brandon
grid-lanes-subgrid-002a
-ref and -expected tests are implemented on a grid, which sets the height of items.
So items 2 and 3 need to be 40 px as that is the height of the grid row 1.
Item 5 is a simple 30px too as that is just the height of the second row.
Now the subgrid requires special attention.
We first need to calculate the height of the subgrid, which is the row 2 + gap + row 3 heights.
Row 2 is a height of 30px, so 4a and 4b I would expect to add up to that.
Row 3 is similar a height of 20px, so we need to set 4c.
Now, we are losing a single pixel as these seem to be resolving to 29px for row 2 and 19px for row 3 heights.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/169113705>
Brandon
Pull request: https://github.com/WebKit/WebKit/pull/57428
EWS
Committed 306411@main (7e6b3bf3ceff): <https://commits.webkit.org/306411@main>
Reviewed commits have been landed. Closing PR #57428 and removing active labels.