Bug 306416
| Summary: | [GTK] Improve IconDatabase logging | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | WebKitGTK | Assignee: | Adrian Perez <aperez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=306580 | ||
| Bug Depends on: | |||
| Bug Blocks: | 301086 | ||
Adrian Perez
Currently UIProcess/API/glib/IconDatabase.cpp uses plain LOG_ERROR() for logging. It would be nicer to use the IconDatabase logging channel to allow easily filter messages using the channel, and while at it improve the messages themselves because most only write a string when database operations fails without including the underlying issue reported by the database.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrian Perez
Pull request: https://github.com/WebKit/WebKit/pull/57399
EWS
Committed 306358@main (8accbbaa5baa): <https://commits.webkit.org/306358@main>
Reviewed commits have been landed. Closing PR #57399 and removing active labels.