Bug 306414
| Summary: | [GTK] Wrong prepared statement creation check in IconDatabase::pruneTimerFired() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | WebKitGTK | Assignee: | Adrian Perez <aperez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=300007 | ||
| Bug Depends on: | |||
| Bug Blocks: | 301086 | ||
Adrian Perez
In IconDatabase::pruneTimerFired() a prepared statement is created if needed; but the condition checking whether the operation succeeded is wrong:
if (!m_pruneIconsStatement) {
m_pruneIconsStatement = m_db->prepareStatement("DELETE FROM IconInfo WHERE stamp <= (?);"_s);
if (m_pruneIconsStatement) { // <----- This is wrong, the error when printed when the prepared statement is valid
LOG_ERROR("Preparing statement pruneIcons failed");
return;
}
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrian Perez
Pull request: https://github.com/WebKit/WebKit/pull/57397
EWS
Committed 306448@main (ca5b100c43e9): <https://commits.webkit.org/306448@main>
Reviewed commits have been landed. Closing PR #57397 and removing active labels.
Adrian Perez
This was actually a regression of 300932@main (bug #300007)