Bug 30633

Summary:

[GTK] EventSender, events synthetization is not correctly initialized

Product:

WebKit

Reporter:

Alejandro G. Castro <alex>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, gustavo

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
First proposal	none
Fixed changelog style	none
Change button variable name to currentEventButton	none
Avoid gdk_window_get_root_coords if the gtk+ release is older than 2.17.3	none
Avoid tmp variables initialization in the gdk_window_get_coords patch	none

Description Alejandro G. Castro 2009-10-21 10:36:50 PDT

In the motion event there is no menset for initializing the memory, we are sending trash inside. And other events do not have some values initialized.

Comment 1 Alejandro G. Castro 2009-10-21 10:53:58 PDT

Created attachment 41575 [details]
First proposal

Comment 2 Alejandro G. Castro 2009-10-21 11:02:29 PDT

Created attachment 41576 [details]
Fixed changelog style

Comment 3 Alejandro G. Castro 2009-10-21 11:13:33 PDT

Created attachment 41582 [details]
Change button variable name to currentEventButton

Comment 4 Xan Lopez 2009-10-21 11:16:49 PDT

Comment on attachment 41582 [details]
Change button variable name to currentEventButton

Looks good to me.

Comment 5 WebKit Commit Bot 2009-10-21 11:55:57 PDT

Comment on attachment 41582 [details]
Change button variable name to currentEventButton

Clearing flags on attachment: 41582

Committed r49912: <http://trac.webkit.org/changeset/49912>

Comment 6 WebKit Commit Bot 2009-10-21 11:56:01 PDT

All reviewed patches have been landed.  Closing bug.

Comment 7 Alejandro G. Castro 2009-10-21 13:20:46 PDT

Created attachment 41604 [details]
Avoid gdk_window_get_root_coords if the gtk+ release is older than 2.17.3

The patch applied requires a new version of gtk+ (2.17.3), in this patch we add a work-around to avoid using the function gdk_window_get_root_coords.

Comment 8 Alejandro G. Castro 2009-10-21 13:36:08 PDT

Created attachment 41606 [details]
Avoid tmp variables initialization in the gdk_window_get_coords patch

Comment 9 Gustavo Noronha (kov) 2009-10-21 13:38:54 PDT

Reopening the bug so that the patch gets landed.

Comment 10 WebKit Commit Bot 2009-10-21 13:47:27 PDT

Comment on attachment 41606 [details]
Avoid tmp variables initialization in the gdk_window_get_coords patch

Clearing flags on attachment: 41606

Committed r49921: <http://trac.webkit.org/changeset/49921>

Comment 11 WebKit Commit Bot 2009-10-21 13:47:31 PDT

All reviewed patches have been landed.  Closing bug.