Bug 306253
| Summary: | [threaded-animations] repeated crash on https://nerdy.dev/anchor-interpolated-morphing | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> |
| Component: | Animations | Assignee: | Antoine Quint <graouts> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | graouts, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Antoine Quint
Loading https://nerdy.dev/anchor-interpolated-morphing with a ToT build crashes every time. We’re hitting this case in `auto ToPlatform<FilterValue>::operator()(const FilterValue& value, const RenderStyle& style)`:
[](const FilterReference&) -> Ref<FilterOperation> {
RELEASE_ASSERT_NOT_REACHED();
}
While we explicitly disallow acceleration for filter animations with reference filters, this code is hit when we’re preparing the base values. We just need to make sure we don’t compute such values when the property is not animated, since in this case we must be animating opacity or a transform-related property.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Antoine Quint
rdar://168778245
Antoine Quint
Pull request: https://github.com/WebKit/WebKit/pull/57243
EWS
Committed 306204@main (0fdb9b7d2bff): <https://commits.webkit.org/306204@main>
Reviewed commits have been landed. Closing PR #57243 and removing active labels.