Bug 306188
| Summary: | REGRESSION(304553@main): [WPE] Cannot build on Android due to 'close' being undefined | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | Tools / Tests | Assignee: | Adrian Perez <aperez> |
| Status: | ASSIGNED | ||
| Severity: | Normal | CC: | alex |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=303921 | ||
Adrian Perez
Probably the difference between glibc/musl headers and bionic, where in the latter <unistd.h> does not get included indirectly:
/home/aperez/wpe/cerbero/build/sources/android_arm64/wpewebkit-2.51.90/Source/WTF/wtf/glib/RunLoopGLib.cpp:124:13: error: use of undeclared identifier 'close'
124 | close(runLoopSource.timerFd);
| ^
1 error generated.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrian Perez
Pull request: https://github.com/WebKit/WebKit/pull/57183