Bug 306102
| Summary: | [WKCI][GLIB] WK2 EWS logic doesn't take into account that there might not be failures in the step layout-tests-repeat-failures (with patch) | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Claudio Saavedra <csaavedra> |
| Component: | Tools / Tests | Assignee: | Carlos Alberto Lopez Perez <clopez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | aakash_jain, clopez, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=306477 | ||
Claudio Saavedra
Currently the WPE layout tests are green enough that tests can pass after the first two runs. That causes the step to run the failing tests without a patch to be skipped, but the step to check for those results runs anyway, causing EWS to choke.
I temporarily commented out a constant failure in WPE to workaround this issue, but we need to fix the logic.
Once this is fixed we should revert https://github.com/WebKit/WebKit/commit/3bf5b6cce0fd6541b74b149d16eced2290f35bbc
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Carlos Alberto Lopez Perez
Pull request: https://github.com/WebKit/WebKit/pull/57119
EWS
Committed 306085@main (65477f1a043f): <https://commits.webkit.org/306085@main>
Reviewed commits have been landed. Closing PR #57119 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/168756331>