Bug 306025 – [WKCI] EWS for WK2 tests for GTK And WPE ports show green on GH PRs when there is an infrastructure issue

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Carlos Alberto Lopez Perez]

This was observed on https://github.com/WebKit/WebKit/pull/56871 .. the EWS bubbles for wpe-wk2 and gtk-wk2 appear green when the test run ended with warnings because it couldn't test the patch because it was generating so many failures that the retry step aborted with OSError: [Errno 7] Argument list too long: b'/bin/bash' when all those tests names were passed via argv

See:
https://ews-build.webkit.org/#/builders/1/builds/115657
https://ews-build.webkit.org/#/builders/34/builds/107233

This is caused because ews-app shows the green icon when the step ends with warnings.

$ cat -n Tools/CISupport/ews-app/ews/common/github.py|grep WARNINGS -C6
   387	                    if queue == 'style':
   388	                        hover_over_text = 'Passed style check'
   389	                    else:
   390	                        hover_over_text = 'Passed tests'
   391	                else:
   392	                    hover_over_text = 'Pass'
   393	        elif build.result == Buildbot.WARNINGS:
   394	            icon = GitHubEWS.ICON_BUILD_PASS
   395	        elif build.result == Buildbot.FAILURE:
   396	            icon = GitHubEWS.ICON_BUILD_FAIL
   397	            hover_over_text = self._most_recent_failure_message(build)
   398	        elif build.result == Buildbot.CANCELLED:
   399	            icon = GitHubEWS.ICON_EMPTY_SPACE


I can understand the logic for that, and its debatable it if should show other icon for warnings. However I think the main problem here is that in case of infrastructure issue the EWS should not report warnings but failure.

[Carlos Alberto Lopez Perez]

Pull request: https://github.com/WebKit/WebKit/pull/57041

[EWS]

Committed 306012@main (1ad1e7a08f87): <https://commits.webkit.org/306012@main>

Reviewed commits have been landed. Closing PR #57041 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/168674551>