Bug 305795
| Summary: | [WebCore] Duplicate make target warnings for JSUnderlyingSourceStartCallback when building JS bindings using DerivedSources.make | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | WebCore Misc. | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 281511 | ||
| Bug Blocks: | |||
David Kilzer (:ddkilzer)
When building WebCore, duplicate make target warnings are generated for JSUnderlyingSourceStartCallback.cpp and JSUnderlyingSourceStartCallback.h:
```
WebCore/DerivedSources.make:2698: warning: overriding commands for target `JSUnderlyingSourceStartCallback.cpp'
WebCore/DerivedSources.make:2698: warning: ignoring old commands for target `JSUnderlyingSourceStartCallback.h'
```
The UnderlyingSourceStartCallback.idl appears twice in the JS_BINDING_IDLS list in DerivedSources.make. This causes the GENERATE_BINDINGS_template macro to generate duplicate build rules for the same targets.
The duplicate entry was introduced in 300392@main for Bug 281511 as an accidental copy-paste error during the large WebIDL refactoring for ReadableStreamDefaultReader C++ conversion.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/168465787>
David Kilzer (:ddkilzer)
Pull request: https://github.com/WebKit/WebKit/pull/56858
EWS
Committed 305844@main (e634ab98b647): <https://commits.webkit.org/305844@main>
Reviewed commits have been landed. Closing PR #56858 and removing active labels.