Bug 305791
| Summary: | REGRESSION(305823@main): Cannot build WeakPtr API tests with Clang 18 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | Tools / Tests | Assignee: | Adrian Perez <aperez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 305754 | ||
| Bug Blocks: | |||
Adrian Perez
There's a number of errors similar to the following:
../../../Tools/TestWebKitAPI/Tests/WTF/WeakPtr.cpp:366:17: error: alias template 'WeakPtr' requires template arguments; argument deduction only allowed for class templates
366 | WeakPtr derivedWeakPtr { derived };
| ^
../../../Tools/TestWebKitAPI/Tests/WTF/WeakPtr.cpp:91:22: note: template is declared here
91 | template<typename T> using WeakPtr = WTF::WeakPtr<T, WeakPtrImplWithCounter>;
| ^
We can add the template parameter explicitly to get those to build. The issue seems to be with the local WeakPtr type alias, which is declared with “using”.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrian Perez
Pull request: https://github.com/WebKit/WebKit/pull/56854
EWS
Committed 305836@main (553115957809): <https://commits.webkit.org/305836@main>
Reviewed commits have been landed. Closing PR #56854 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/168466137>