Bug 305788
| Summary: | [GStreamer][Broadcom] fix incorrect casting of GstGhostPad to GstElement | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Enrique Ocaña <eocanha> |
| Component: | New Bugs | Assignee: | Enrique Ocaña <eocanha> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Enrique Ocaña
The problem is observed when brcm audio/video filters are plugged into the "inner-parser" in WebKitThunderParser. GStreamerQuirkBroadcomBase::setupBufferingPercentageCorrection() tries and fails to cast GstGhostPad to GstElement. The gst_pad_get_parent_element() method fits better for the use case.
Also, it would be nice to disables the correction of buffering percentage for MSE and MediaStream playbacks, since it only makes sense for regular playback.
See: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/1596
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Enrique Ocaña
Pull request: https://github.com/WebKit/WebKit/pull/56849
EWS
Committed 305877@main (c4980bb736ef): <https://commits.webkit.org/305877@main>
Reviewed commits have been landed. Closing PR #56849 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/168495547>