Bug 305726
| Summary: | Add new IDL bindings extended attribute for dictionaries that still require using RefPtr for required interfaces | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> |
| Component: | Bindings | Assignee: | Sam Weinig <sam> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cdumez, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari 18 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 305410 | ||
Sam Weinig
As a first step toward removing support for dictionaries using RefPtr for required interfaces, we should add a new IDL bindings extended attribute for all the dictionaries that still use it and attach that attribute to all the dictionaries.
For any dictionary without the new attribute (and therefore using Ref<> for any required interfaces), we implement a new conversion implementation that does "one-shot" initialization. This will require that the native struct now also have the same order as the IDL dictionary.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sam Weinig
Pull request: https://github.com/WebKit/WebKit/pull/56790
EWS
Committed 305790@main (2bb1d31a0fa7): <https://commits.webkit.org/305790@main>
Reviewed commits have been landed. Closing PR #56790 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/168422398>