Summary: | [Qt] webcore.pro incorrect linking of sqlite3 on Symbian | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Janne Koskinen <koshuin> | ||||
Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Critical | CC: | commit-queue, laszlo.gombos | ||||
Priority: | P2 | Keywords: | Qt | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | S60 Hardware | ||||||
OS: | S60 3rd edition | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 27065 | ||||||
Attachments: |
|
Description
Janne Koskinen
2009-10-20 06:41:58 PDT
Created attachment 41504 [details]
proposed fix for webcore.pro
Comment on attachment 41504 [details]
proposed fix for webcore.pro
This looks fine to me. Seems a qt person would be a better reviewer though.
Comment on attachment 41504 [details]
proposed fix for webcore.pro
LGTM
Comment on attachment 41504 [details]
proposed fix for webcore.pro
Rejecting patch 41504 from commit-queue.
Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11506 test cases.
fast/media/mq-transform-02.html -> failed
Exiting early after 1 failures. 7441 tests run.
139.03s total testing time
7440 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
3 test cases (<1%) had stderr output
Comment on attachment 41504 [details]
proposed fix for webcore.pro
Sorry about the commit-queue trouble. Should work fine now.
Comment on attachment 41504 [details] proposed fix for webcore.pro Clearing flags on attachment: 41504 Committed r49986: <http://trac.webkit.org/changeset/49986> All reviewed patches have been landed. Closing bug. |