Bug 305678
| Summary: | Temporarily revert assertion in VMTraps::deferTerminationSlow() to a Debug ASSERT. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | Keywords: | InRadar |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Mark Lam
There are places in the code that are still not handling TerminationExceptions correctly, and re-entering the VM after termination. As a result, they are crashing over this RELEASE_ASSERT which was hardened from a Debug ASSERT in 298039@main. If the client re-enters the VM while the TerminationException is still in effect, without this RELEASE_ASSERT, we'll eventually exit again at the next exception check. So, the issue should be benign. This patch will temporarily revert the RELEASE_ASSERT back to a Debug ASSERT to alleviate the crashes.
We still want to fix all the places that did the illegal re-entry to make the code more sane and easy to reason about, but that can be done later. We can re-enable the RELEASE_ASSERT after that.
rdar://167947484
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Mark Lam
Duplicate entry of https://bugs.webkit.org/show_bug.cgi?id=305677.
*** This bug has been marked as a duplicate of bug 305677 ***