Bug 305434
| Summary: | Remove CanMakeCheckedPtr base for Style::ComputedStyleBase to recoup style size regression | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> |
| Component: | CSS | Assignee: | Sam Weinig <sam> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | koivisto, sabouhallawa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari 18 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Sam Weinig
When splitting Style::ComputedStyle from RenderStyle, making Style::ComputedStyleBase inherit from CanMakeCheckedPtr while also having RenderStyle inherit from CanMakeCheckedPtr, caused all RenderStyles to grow.
Eventually, RenderStyle will just be a wrapper around a CheckedRef<const Style::ComputedStyle> but for now, we need to remove one of them.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sam Weinig
Pull request: https://github.com/WebKit/WebKit/pull/56531
Said Abou-Hallawa
rdar://167815714
EWS
Committed 305612@main (3c71c8f9aac6): <https://commits.webkit.org/305612@main>
Reviewed commits have been landed. Closing PR #56531 and removing active labels.