Bug 305422
| Summary: | tiktok.com: [macOS] Please upgrade to the latest version of your browser - message on upload | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> |
| Component: | New Bugs | Assignee: | Brent Fulgham <bfulgham> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Brent Fulgham
We have the unfortunate architecture of two separate “Custom User Agent” values governing page loads and the Navigator API (see Bug 305420). One is called customUserAgent, and was the field we populated when fixing the iOS version of this bug.
There is also a customUserAgentAsSiteSpecificQuirks field, which happens to be used in the macOS case. Because this value was present, the Navigator API was using it in preference to the customUserAgent field set in WebsitePolicies.
This caused my attempted fix in Bug 291113 to start failing as soon as a quirks-level custom URL scheme was set on macOS.
For now, I’m just applying the same fix to customUserAgentAsSiteSpecificQuirks (if it exists) so that whichever flavor of custom URL is in place, it is tweaked with the necessary like Chrome/136 string.
I will see if we can streamline and simplify the handling of custom User Agent separately in Bug 305420.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Brent Fulgham
rdar://166837052
Brent Fulgham
Pull request: https://github.com/WebKit/WebKit/pull/56522
EWS
Committed 305598@main (f4cfd452ee0a): <https://commits.webkit.org/305598@main>
Reviewed commits have been landed. Closing PR #56522 and removing active labels.