Bug 305413
| Summary: | Make toJS() conversions require correct nullness and subtyping, take 2 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> |
| Component: | Bindings | Assignee: | Anne van Kesteren <annevk> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | annevk, cdumez, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari 18 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 305621 | ||
| Bug Blocks: | |||
Sam Weinig
Current the generated toJS() functions allow callers to pass in null values, automatically return jsNull(). This makes the bindings pretty non-strict about specifying whether an attribute or operation return type are nullable or not, and as a result, we get it wrong a lot. They also don't actually check that the type is the type or a subtype.
Anne took a crack at this problem in https://bugs.webkit.org/show_bug.cgi?id=305252, this is my crack at it.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sam Weinig
Pull request: https://github.com/WebKit/WebKit/pull/56513
EWS
Committed 305676@main (f96aecc3dd48): <https://commits.webkit.org/305676@main>
Reviewed commits have been landed. Closing PR #56513 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/168260035>
Jonathan Bedard
Reopened Bugzilla.
REGRESSION(305676@main): Broke all Apple Internal builds, tracking revert in https://bugs.webkit.org/show_bug.cgi?id=305621.
Anne van Kesteren
<rdar://168284687>
Anne van Kesteren
Pull request: https://github.com/WebKit/WebKit/pull/56696
EWS
Committed 305702@main (c6f87a59606a): <https://commits.webkit.org/305702@main>
Reviewed commits have been landed. Closing PR #56696 and removing active labels.
Anne van Kesteren
*** Bug 305252 has been marked as a duplicate of this bug. ***