Bug 30537 – webkit-patch create-bug should support attaching a series of patches

• Component: Tools / Tests
• Status: NEW

[Adam Roben (:aroben)]

To reproduce:

1. Run this command: bugzilla-tool create-bug HEAD^..
2. Answer all the prompts

The bug gets created and the first patch gets attached. Then you get an exception like this:

Traceback (most recent call last):
  File "/home/Adam Roben/dev/WebKit/OpenSource/WebKitTools/Scripts/bugzilla-tool", line 904, in <module>
    main()
  File "/home/Adam Roben/dev/WebKit/OpenSource/WebKitTools/Scripts/bugzilla-tool", line 901, in main
    return tool.main()
  File "/home/Adam Roben/dev/WebKit/OpenSource/WebKitTools/Scripts/bugzilla-tool", line 896, in main
    return command_object.execute(command_options, command_args, self)
  File "/home/Adam Roben/dev/WebKit/OpenSource/WebKitTools/Scripts/bugzilla-tool", line 629, in execute
    self.create_bug_from_commit(options, args, tool)
  File "/home/Adam Roben/dev/WebKit/OpenSource/WebKitTools/Scripts/bugzilla-tool", line 592, in create_bug_from_commit
    PostCommitsAsPatchesToBug.execute(self, options, commit_ids[1:], tool)
TypeError: unbound method execute() must be called with PostCommitsAsPatchesToBug instance as first argument (got CreateBug instance instead)

[David Kilzer (:ddkilzer)]

The issue is that create-bug only supports one patch to be posted to a new bug.  The failing command is trying to attach two patches to the new bug.

[Eric Seidel (no email)]

This usage has fallen out of fashion due to "webkit-patch upload" but it's possible that there are still consumers of this command.

[David Kilzer (:ddkilzer)]

(In reply to comment #2)
> This usage has fallen out of fashion due to "webkit-patch upload" but it's
> possible that there are still consumers of this command.

The short description for webkit-patch says nothing about creating a new bug, so I never looked at it until I saw the above comment.

[Eric Seidel (no email)]

Yes.  All of the various Commands need better help.

If you'd like to submit patches the "help_text" (short one-line help) and "long_help" (man-page-like help) class members are the things to set:
    help_text = "Print the status of the %s buildbots" % BuildBot.default_host
    long_help = """Fetches build status from http://build.webkit.org/one_box_per_builder
and displayes the status of each builder."""

That's a poor example of a good "long_help: but you get the idea. :)

[David Kilzer (:ddkilzer)]

(In reply to comment #3)
> (In reply to comment #2)
> > This usage has fallen out of fashion due to "webkit-patch upload" but it's
> > possible that there are still consumers of this command.
> 
> The short description for webkit-patch says nothing about creating a new bug,
> so I never looked at it until I saw the above comment.

Thanks for the info, Eric.  But "webkit-patch" upload is not git-friendly and thus doesn't allow a series of patches to be uploaded, which is what I wanted to do for Bug 36560.

[Eric Seidel (no email)]

webkit-patch post-commits should still work for a series of patches. But I haven't personally used that in ages.

[Eric Seidel (no email)]

I am truly just a git-poser.  I use git, but instead of local branches I mostly use bugs to hold my patches (using webkit-patch upload and webkit-patch apply-attachment).

[Eric Seidel (no email)]

These days "webkit-patch upload" is the new hotness.  It still doesn't support attaching a series of patches, but that is probably where such changes should go instead of create-bug.  upload will create a bug if needed.