Bug 305194 – [GCC] Fails to build bmalloc with -O1

• Component: bmalloc
• Status: RESOLVED FIXED

[Carlos Alberto Lopez Perez]

Trying to build WPE with -O1 and GCC results in:

[7/2467] Building C object Source/bmalloc/CMakeFiles/bmalloc.dir/libpas/src/libpas/pas_simple_large_free_heap.c.o
FAILED: Source/bmalloc/CMakeFiles/bmalloc.dir/libpas/src/libpas/pas_simple_large_free_heap.c.o 
/usr/bin/ccache /usr/bin/cc -DBUILDING_WEBKIT=1 -DBUILDING_WITH_CMAKE=1 -DBUILDING_WPE__=1 -DBUILDING_bmalloc -DBWRAP_EXECUTABLE=\"/usr/bin/bwrap\" -DDBUS_PROXY_EXECUTABLE=\"/usr/bin/xdg-dbus-proxy\" -DGETTEXT_PACKAGE=\"WPE\" -DHAVE_CONFIG_H=1 -DJSC_GLIB_API_ENABLED -DPAS_BMALLOC=1 -D_GLIBCXX_ASSERTIONS=1 -D_GNU_SOURCE -I/sdk/webkit/Source/bmalloc -I/sdk/webkit/Source/bmalloc/bmalloc -I/sdk/webkit/Source/bmalloc/libpas/src/libpas -fdiagnostics-color=always -Wextra -Wall -pipe -fmax-errors=20 -Wno-expansion-to-defined -Wno-psabi -Wno-misleading-indentation -Wno-maybe-uninitialized -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -Wno-tautological-compare -fdebug-types-section -fno-omit-frame-pointer -O1 -fno-strict-aliasing -fno-exceptions -ffunction-sections -fdata-sections -g -fPIC -fvisibility=hidden -Werror -Wno-cast-align -Wno-missing-field-initializers -MD -MT Source/bmalloc/CMakeFiles/bmalloc.dir/libpas/src/libpas/pas_simple_large_free_heap.c.o -MF Source/bmalloc/CMakeFiles/bmalloc.dir/libpas/src/libpas/pas_simple_large_free_heap.c.o.d -o Source/bmalloc/CMakeFiles/bmalloc.dir/libpas/src/libpas/pas_simple_large_free_heap.c.o -c /sdk/webkit/Source/bmalloc/libpas/src/libpas/pas_simple_large_free_heap.c
In file included from ../../../Source/bmalloc/libpas/src/libpas/pas_simple_large_free_heap.c:33:
In function ‘simple_find_first’,
    inlined from ‘pas_generic_large_free_heap_try_allocate’ at ../../../Source/bmalloc/libpas/src/libpas/pas_generic_large_free_heap.h:206:5,
    inlined from ‘try_allocate_without_fixing’ at ../../../Source/bmalloc/libpas/src/libpas/pas_simple_large_free_heap.c:398:12:
../../../Source/bmalloc/libpas/src/libpas/pas_generic_large_free_heap.h:140:1: error: inlining failed in call to ‘always_inline’ ‘pas_generic_large_free_heap_try_allocate_test_allocation_candidate’: indirect function call with a yet undetermined callee
  140 | pas_generic_large_free_heap_try_allocate_test_allocation_candidate(
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../../Source/bmalloc/libpas/src/libpas/pas_simple_large_free_heap.c:242:9: note: called from here
  242 |         test_candidate(index_to_cursor(index), candidate, arg);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../../Source/bmalloc/libpas/src/libpas/pas_generic_large_free_heap.h:140:1: error: inlining failed in call to ‘always_inline’ ‘pas_generic_large_free_heap_try_allocate_test_allocation_candidate’: indirect function call with a yet undetermined callee
  140 | pas_generic_large_free_heap_try_allocate_test_allocation_candidate(
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../../Source/bmalloc/libpas/src/libpas/pas_simple_large_free_heap.c:242:9: note: called from here
  242 |         test_candidate(index_to_cursor(index), candidate, arg);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[11/2433] Building C object Source/bmalloc/CMakeFiles/bmalloc.dir/libpas/src/libpas/pas_fast_large_free_heap.c.o
FAILED: Source/bmalloc/CMakeFiles/bmalloc.dir/libpas/src/libpas/pas_fast_large_free_heap.c.o 
/usr/bin/ccache /usr/bin/cc -DBUILDING_WEBKIT=1 -DBUILDING_WITH_CMAKE=1 -DBUILDING_WPE__=1 -DBUILDING_bmalloc -DBWRAP_EXECUTABLE=\"/usr/bin/bwrap\" -DDBUS_PROXY_EXECUTABLE=\"/usr/bin/xdg-dbus-proxy\" -DGETTEXT_PACKAGE=\"WPE\" -DHAVE_CONFIG_H=1 -DJSC_GLIB_API_ENABLED -DPAS_BMALLOC=1 -D_GLIBCXX_ASSERTIONS=1 -D_GNU_SOURCE -I/sdk/webkit/Source/bmalloc -I/sdk/webkit/Source/bmalloc/bmalloc -I/sdk/webkit/Source/bmalloc/libpas/src/libpas -fdiagnostics-color=always -Wextra -Wall -pipe -fmax-errors=20 -Wno-expansion-to-defined -Wno-psabi -Wno-misleading-indentation -Wno-maybe-uninitialized -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -Wno-tautological-compare -fdebug-types-section -fno-omit-frame-pointer -O1 -fno-strict-aliasing -fno-exceptions -ffunction-sections -fdata-sections -g -fPIC -fvisibility=hidden -Werror -Wno-cast-align -Wno-missing-field-initializers -MD -MT Source/bmalloc/CMakeFiles/bmalloc.dir/libpas/src/libpas/pas_fast_large_free_heap.c.o -MF Source/bmalloc/CMakeFiles/bmalloc.dir/libpas/src/libpas/pas_fast_large_free_heap.c.o.d -o Source/bmalloc/CMakeFiles/bmalloc.dir/libpas/src/libpas/pas_fast_large_free_heap.c.o -c /sdk/webkit/Source/bmalloc/libpas/src/libpas/pas_fast_large_free_heap.c
In file included from ../../../Source/bmalloc/libpas/src/libpas/pas_fast_large_free_heap.c:32:
In function ‘fast_find_first’,
    inlined from ‘pas_generic_large_free_heap_try_allocate’ at ../../../Source/bmalloc/libpas/src/libpas/pas_generic_large_free_heap.h:206:5,
    inlined from ‘pas_fast_large_free_heap_try_allocate’ at ../../../Source/bmalloc/libpas/src/libpas/pas_fast_large_free_heap.c:423:12:
../../../Source/bmalloc/libpas/src/libpas/pas_generic_large_free_heap.h:140:1: error: inlining failed in call to ‘always_inline’ ‘pas_generic_large_free_heap_try_allocate_test_allocation_candidate’: indirect function call with a yet undetermined callee
  140 | pas_generic_large_free_heap_try_allocate_test_allocation_candidate(
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../../Source/bmalloc/libpas/src/libpas/pas_fast_large_free_heap.c:152:13: note: called from here
  152 |         if (test_candidate((pas_generic_large_free_cursor*)node, node->free, arg))
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[Carlos Alberto Lopez Perez]

Pull request: https://github.com/WebKit/WebKit/pull/56331

[EWS]

Committed 305359@main (1596b2e351a2): <https://commits.webkit.org/305359@main>

Reviewed commits have been landed. Closing PR #56331 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/167844253>