Bug 305186
| Summary: | REGRESSION(304666@main) [WPE] Build broken when DEVELOPER_MODE=OFF due to undefined symbols when linking jsc | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> |
| Component: | WPE WebKit | Assignee: | Carlos Alberto Lopez Perez <clopez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, psaavedra |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=304326 | ||
Carlos Alberto Lopez Perez
304666@main introduced an optimization in WPE to link the jsc binary and other test binaries against libWPEWebKit instead of statically linking (embedding) WTF, JSC and other libraries inside.
However, it happens that when DEVELOPER_MODE is not enabled we pass a linker filter to libWPEWebKit that makes many of the symbols (JSC::* WTF:*) required to link this binaries not longer visible.
Thanks to Pablo Saavedra for the original report and an initial patch proposal
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Carlos Alberto Lopez Perez
This is the filter:
Source/WebKit/PlatformWPE.cmake-if (NOT DEVELOPER_MODE AND NOT CMAKE_SYSTEM_NAME MATCHES "Darwin")
Source/WebKit/PlatformWPE.cmake: WEBKIT_ADD_TARGET_PROPERTIES(WebKit LINK_FLAGS "-Wl,--version-script,${CMAKE_CURRENT_SOURCE_DIR}/webkitglib-symbols.map")
Source/WebKit/PlatformWPE.cmake: set_property(TARGET WebKit APPEND PROPERTY LINK_DEPENDS "${CMAKE_CURRENT_SOURCE_DIR}/webkitglib-symbols.map")
Source/WebKit/PlatformWPE.cmake-endif ()
Carlos Alberto Lopez Perez
Pull request: https://github.com/WebKit/WebKit/pull/56323
EWS
Committed 305354@main (6d81a49969e7): <https://commits.webkit.org/305354@main>
Reviewed commits have been landed. Closing PR #56323 and removing active labels.