Bug 305134
| Summary: | Some wasm js-string builtins have incorrect signatures | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kai Tamkun <k_tamkun> |
| Component: | WebAssembly | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Kai Tamkun
rdar://166830652
cast, fromCharCode, fromCodePoint, concat and substring are currently marked as returning `externref` (nullable).
The correct return type is `(ref extern)` (nonnullable) because these functions can never return null.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Kai Tamkun
Pull request: https://github.com/WebKit/WebKit/pull/56362
EWS
Committed 305487@main (22b6a610f6ff): <https://commits.webkit.org/305487@main>
Reviewed commits have been landed. Closing PR #56362 and removing active labels.