Bug 305115 – chromestatus.com: Misplaced clear button in search field

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[alan]

<rdar://166754216>

[alan]

Created attachment 477934 [details]
[fast-cq]Patch

[Lily Spiniolas]

Comment on attachment 477934 [details]
[fast-cq]Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=477934&action=review

> Source/WebCore/html/shadow/DataListButtonElement.h:67
> +        auto* htmlElement = dynamicDowncast<WebCore::HTMLElement>(node);

We should probably use a RefPtr here

[alan]

(In reply to Lily Spiniolas from comment #2)
> Comment on attachment 477934 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=477934&action=review
> 
> > Source/WebCore/html/shadow/DataListButtonElement.h:67
> > +        auto* htmlElement = dynamicDowncast<WebCore::HTMLElement>(node);
> 
> We should probably use a RefPtr here

We indeed should!

[alan]

actually "isDataListButtonElement" is trivial so no need to use RefPtr AFAICT.

[EWS]

Committed 305314@main (7313736adae0): <https://commits.webkit.org/305314@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 477934 [details].

[Alejandro G. Castro]

This is causing a crash in the GTK tests, any idea of how to fix it, the backtrace is here:

https://build.webkit.org/results/WPE-Linux-64-bit-Release-Tests/305349@main%20(24537)/fast/forms/datalist/data-list-search-input-with-appearance-none-crash-log.txt

[alan]

This looks to be about the test itself and not the code change (WTR::UIScriptController::isShowingDataListSuggestions() crashes). I don't have a clear understanding of the current status of the GTK UIScriptController implementation, but if it's blocking EWS on GTK, I'd skip the test for now.

[Alejandro G. Castro]

Ok, thanks for the feedback!