Bug 305014
| Summary: | REGRESSION(304987@main): Broke http/tests/webgpu/webgpu/web_platform/copyToTexture/video.html | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> |
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer, ysuzuki |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 304740 | ||
Jonathan Bedard
After 305168@main, http/tests/webgpu/webgpu/web_platform/copyToTexture/video.html started failing. Seems likely to be a rebaseline.
History:
https://results.webkit.org/?suite=layout-tests&test=http/tests/webgpu/webgpu/web_platform/copyToTexture/video.html
Build:
https://build.webkit.org/#/builders/1716/builds/1009
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/167652123>
Jonathan Bedard
Reproduction:
run-webkit-tests --no-build --no-retry --no-show-results --exit-after-n-failures=1 --expect-pass --iterations=1000 --force --release http/tests/webgpu/webgpu/web_platform/copyToTexture/video.html
Ryan Haddad
Based on the history link, it looks like this started failing with https://commits.webkit.org/304987@main, no?
Ryan Haddad
diff:
```
--- /Volumes/Data/worker/Apple-Sonoma-Release-AppleSilicon-WK2-Tests/build/layout-test-results/http/tests/webgpu/webgpu/web_platform/copyToTexture/video-expected.txt
+++ /Volumes/Data/worker/Apple-Sonoma-Release-AppleSilicon-WK2-Tests/build/layout-test-results/http/tests/webgpu/webgpu/web_platform/copyToTexture/video-actual.txt
@@ -14,7 +14,6 @@
eventualExpectOK@http://127.0.0.1:8000/webgpu/common/framework/fixture.js:414:34
expectSinglePixelComparisonsAreOkInTexture@http://127.0.0.1:8000/webgpu/webgpu/texture_test_utils.js:238:21
@http://127.0.0.1:8000/webgpu/webgpu/web_platform/copyToTexture/video.spec.js:105:53
- @http://127.0.0.1:8000/webgpu/webgpu/web_platform/copyToTexture/video.spec.js:64:60
```
`video.spec.js:64` appears to be an await function, so it seems related to 304987@main based on the commit message
Ryan Haddad
I don't see the test having failed on the PR for that commit, but it looks like the whole directory is marked as flaky so it isn't running on EWS (due to the --skip-failing-tests argument)
LayoutTests/platform/mac-wk2/TestExpectations:2364:http/tests/webgpu/webgpu/web_platform/copyToTexture [ Pass Timeout ]
Jonathan Bedard
Yes, regression point is https://commits.webkit.org/304987@main, I fat-fingered the commit in the original report.