Bug 304998
| Summary: | Add Cmd-T tab support to MiniBrowser with native macOS tabbing | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | zak ridouh <zakr> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
zak ridouh
Currently, to enter into the multi-tab view creating a new window from the menu bar, then "merging" windows.
Since the functionality is already there, wire up Cmd-T support, and use the native macOS application tabbing behavior to make it less "awkward" to add new tabs.
By using the native macOS tabbing behavior, we get a lot of functionality "for free", such as:
- Cmd-T to create new tabs
- Window > Merge All Windows
- Window > Move Tab to New Window
- Dragging tabs between windows
In this patch,
- Added tabbingMode="preferred" to BrowserWindow.xib to enable native tab bar
- Added "New Tab" menu item (Cmd-T) to File menu
- Implement newTab: action that creates tabs inheriting the current window's type (WK1/WK2) and configuration (private browsing, site isolation)
- Added tabbingIdentifier to group windows properly
- Use separate tabbingIdentifier for private windows to prevent merging with regular windows
- Implemented newWindowForTab: delegate for the tab bar "+" button
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/167638810>
zak ridouh
Pull request: https://github.com/WebKit/WebKit/pull/56148
EWS
Committed 305262@main (0280081ab6aa): <https://commits.webkit.org/305262@main>
Reviewed commits have been landed. Closing PR #56148 and removing active labels.