Summary: | [Gtk] The document frame/html container claims to be parentless | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joanmarie Diggs <jdiggs> | ||||||
Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | apinheiro, commit-queue, walker.willie, xan.lopez | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 25531 | ||||||||
Attachments: |
|
Description
Joanmarie Diggs
2009-10-17 22:48:18 PDT
Created attachment 41392 [details]
possible fix
It's ugly, but it works.
If there's already a method that works to reliably get the accessible parent of the WebView, and I managed to miss it, do please let me know. Otherwise, please review. Thanks!
Created attachment 41411 [details]
revision 2 - made changes Xan suggested
xan: OK, two really minor things: I think it's worth adding a comment here explaining why are we doing this, and the last NULL check I think you can get rid of, since you'd return NULL anyway
xan: I mean the one checking what gtk_widget_get_accessible returns, just return gtk_widget_get_accessible
----
Done.
Comment on attachment 41411 [details]
revision 2 - made changes Xan suggested
Bam!
Comment on attachment 41411 [details] revision 2 - made changes Xan suggested Clearing flags on attachment: 41411 Committed r49775: <http://trac.webkit.org/changeset/49775> All reviewed patches have been landed. Closing bug. |