Bug 30473 – Check COMPILER(MSVC) instead of PLATFORM(WIN_OS) to avoid the use of vasprintf.

• Component: DOM
• Status: RESOLVED FIXED

[Kwang Yul Seo]

vasprintf is missing in MSVC. Use COMPILER(MSVC) guards instead of PLALTFORM(WIN_OS) guards.

[Kwang Yul Seo]

Created attachment 41349 [details]
Use COMPILER(MSVC) guards to avoid vasprintf

[Eric Seidel (no email)]

So you're saying that vasprintf works fine in gcc (or any other compiler) on WIN_OS?

[Kwang Yul Seo]

I use MSVC to build WebKit for BREW simulator and I undefined WTF_PLATFORM WIN_OS in Platform.h in favor of WTF_PLATFORM_BREW. vasprintf is not related to WIN_OS but to MSVC.

vasprintf works fine in cygwin or mingw gcc anyway.

[Eric Seidel (no email)]

I could have sworn bdash commented on this bug already, but I don't see it.

[Eric Seidel (no email)]

Comment on attachment 41349 [details]
Use COMPILER(MSVC) guards to avoid vasprintf

+        No new tests. (OOPS!)

the OOPS will cause the commit to fail.  The one in "reviewed by" is OK, because the commit-queue will substitute in the right thing.  BUt the no new tests line should be replaced by something explaingin why this does not need testing or why testing is impossible.

Something simple like:

Build fix only, no tests possible.

would be fine.

cq- since the commit-queue can't handle this as-is.  If you post a new patch  w/o the second OOPS! that can be r+/cq+'d though.

[Adam Barth]

Committed r49838: <http://trac.webkit.org/changeset/49838>

[Lucas Forschler]

Mass moving XML DOM bugs to the "DOM" Component.