Bug 304717
| Summary: | RenderGrid's self-alignment property handling is a tangled mess | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | fantasai <fantasai.bugs> |
| Component: | Layout and Rendering | Assignee: | fantasai <fantasai.bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, brandonstewart, sgill26, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 304716 | ||
| Bug Blocks: | 304715 | ||
fantasai
The self-alignment property handling in RenderGrid is a mess:
- We retrieve the alignment value in multiple places, in inconsistent ways, which is a recipe for bugs.
- We push some of the code handling up into RenderBox, which is a superclass that shouldn't need to have grid-specific code in it.
As a result, the whole system for piping "is this a stretched item" through our rendering code is a tangled mess, and it's difficult to make any adjustments (e.g. to handle grid-lanes layout or any other new rules) correctly and thoroughly.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/167221679>
fantasai
Pull request: https://github.com/WebKit/WebKit/pull/55887
EWS
Committed 305260@main (810cb2deb144): <https://commits.webkit.org/305260@main>
Reviewed commits have been landed. Closing PR #55887 and removing active labels.