Bug 304716
| Summary: | API for self-alignment properties awkwardly loops layout logic through RenderStyle APIs | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | fantasai <fantasai.bugs> |
| Component: | CSS | Assignee: | fantasai <fantasai.bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | koivisto, sam, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 304717 | ||
fantasai
The way StyleSelfAlignmentData resolution loops formatting-context-specific 'normal' resolution through it creates awkward calling patterns in layout code, doesn't generalize well because normal resolution is formatting-context-specific, and requires excess up-front work even when it's not needed. At the same time, it pushes 'auto' resolution into layout code even though that's much more of a style computation thing. We should flip the API so that the style code handles auto resolution, and the layout code handles normal resolution.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/167221674>
fantasai
Pull request: https://github.com/WebKit/WebKit/pull/55886
EWS
Committed 305146@main (fd2edbac21f5): <https://commits.webkit.org/305146@main>
Reviewed commits have been landed. Closing PR #55886 and removing active labels.