Bug 304707
| Summary: | [GTK][WPE] Fix non-unified builds, early 2026 edition | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | Tools / Tests | Assignee: | Adrian Perez <aperez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | michael, simon.fraser, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 304787, 307208 | ||
| Bug Blocks: | |||
Adrian Perez
🎄
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrian Perez
Pull request: https://github.com/WebKit/WebKit/pull/55879
Michael Nutt
I ran into these same issues and started looking into it before searching Bugzilla (oops!). I'm happy to defer to the above PR but it is somewhat out of date at this point. I opened an up-to-date one here: https://github.com/WebKit/WebKit/pull/62244 which should be ready for review, if the old one is not still being worked on.
EWS
Committed 310870@main (a1426e112eee): <https://commits.webkit.org/310870@main>
Reviewed commits have been landed. Closing PR #62244 and removing active labels.
Simon Fraser (smfr)
This broke macOS/iOS builds:
https://commits.webkit.org/310884@main
https://commits.webkit.org/310899@main
Please be aware that if you add an #include to a "private" framework header on macOS/iOS, the includes need to be framework-style: #include <WebCore/Foo.h>
Radar WebKit Bug Importer
<rdar://problem/174464928>