Bug 304646
| Summary: | Remove the need to explicitly pass a EXPORT macro to TZONE_ALLOCATED_EXPORT macros. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> |
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | commit-queue, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 304664 | ||
| Bug Blocks: | |||
Mark Lam
The needed EXPORT macro is always satisfied by WTF_EXPORT_PRIVATE. All the variants that are passed in ultimately maps to same underlying macros as WTF_EXPORT_PRIVATE anyway. Hence, we can remove this bit of unnecessary friction.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/167090364>
Mark Lam
Pull request: https://github.com/WebKit/WebKit/pull/55831
EWS
Committed 304910@main (d65c13db1fdf): <https://commits.webkit.org/304910@main>
Reviewed commits have been landed. Closing PR #55831 and removing active labels.
WebKit Commit Bot
Re-opened since this is blocked by bug 304664
Mark Lam
Turns out, we can't just use WTF_EXPORT_PRIVATE in JSC, WebCore, and other higher layers. So, this bug / request is invalid to begin with.