Bug 304645
| Summary: | Fix Objective-C leaks caused by missing -dealloc and missing -release | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | WebKit Misc. | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
David Kilzer (:ddkilzer)
Fix Objective-C leaks caused by missing -dealloc and missing -release.
```
Source/WebKit/UIProcess/mac/_WKCaptionStyleMenuControllerMac.mm:53:1: warning: 'WKCaptionStyleMenuController' lacks a 'dealloc' instance method but must release '_savedActiveProfileID' [osx.cocoa.Dealloc]
53 | @implementation WKCaptionStyleMenuController
| ^
1 warning generated.
Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticationExtensionsClientInputs.mm:34:5: warning: The '_eval' ivar in '_WKAuthenticationExtensionsClientInputs' was copied by a synthesized property but not released before '[super dealloc]' [osx.cocoa.Dealloc]
34 | [super dealloc];
| ^~~~~~~~~~~~~~~
Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticationExtensionsClientInputs.mm:34:5: warning: The '_evalByCredential' ivar in '_WKAuthenticationExtensionsClientInputs' was copied by a synthesized property but not released before '[super dealloc]' [osx.cocoa.Dealloc]
34 | [super dealloc];
| ^~~~~~~~~~~~~~~
Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticationExtensionsClientInputs.mm:34:5: warning: The '_largeBlob' ivar in '_WKAuthenticationExtensionsClientInputs' was copied by a synthesized property but not released before '[super dealloc]' [osx.cocoa.Dealloc]
34 | [super dealloc];
| ^~~~~~~~~~~~~~~
3 warnings generated.
```
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/167089343>
David Kilzer (:ddkilzer)
Pull request: https://github.com/WebKit/WebKit/pull/55836
EWS
Committed 305337@main (fd984eb67bc8): <https://commits.webkit.org/305337@main>
Reviewed commits have been landed. Closing PR #55836 and removing active labels.