Bug 304314
| Summary: | Refine the criteria for which tests dump frame load callbacks | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | Tools / Tests | Assignee: | Darin Adler <darin> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | darin, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Simon Fraser (smfr)
Currently we have:
m_dumpFrameLoadCallbacks = urlContains("loading/"_s) && !urlContains("://localhost"_s);
but that causes frame load callbacks to dump for `css/css-font-loading`, which is undesirable. This fills the results with:
main frame - didStartProvisionalLoadForFrame
main frame - didCommitLoadForFrame
main frame - didReceiveTitle: Tests FontFaceSet loading event
main frame - didFinishDocumentLoadForFrame
main frame - didHandleOnloadEventsForFrame
main frame - didFinishLoadForFrame
which can also add flakiness (based on when the title is set).
We use immediately switch to `/loading/` and later move this into the tests themselves.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/166845643>
Darin Adler
Pull request: https://github.com/WebKit/WebKit/pull/55673
EWS
Committed 305432@main (bf5c2a8d3ba9): <https://commits.webkit.org/305432@main>
Reviewed commits have been landed. Closing PR #55673 and removing active labels.