Bug 304185
| Summary: | Abstract Swift and C++ handleMessage differences | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | adrian_taylor |
| Component: | WebKit Process Model | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | nham, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
adrian_taylor
We recently introduced the ability for the IPC handleMessage code to call directly into Swift message handling functions, via Swift/C++ interop. This led to the various 'handleMessage' functions becoming full of highly nested 'if' clauses, due to the different behavior for Swift and C++. We should extract these differences into the (pre-existing) MethodSignatureValidation structure, such that the 'handleMessage' functions themselves can regain their former simplicity.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
adrian_taylor
<rdar://problem/165213339>
adrian_taylor
Pull request: https://github.com/WebKit/WebKit/pull/55411
EWS
Committed 304670@main (e935d39eecd2): <https://commits.webkit.org/304670@main>
Reviewed commits have been landed. Closing PR #55411 and removing active labels.