Bug 304172
| Summary: | REGRESSION(300618@main): `letter-spacing` transition no longer works | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> |
| Component: | Animations | Assignee: | Sam Weinig <sam> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | graouts, sam, webkit-bug-importer, webkit |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Antoine Quint
It was reported on Reddit (https://www.reddit.com/r/css/comments/1ple3jq/safari_262_bug_animated_letterspacing/) that `letter-spacing` transitions don't work anymore. Using the test at https://output.jsbin.com/meweci/1 I managed to regress it to 300618@main, the fix for bug 299314.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/166530064>
Sam Weinig
Guessing we need to change conservativelyCollectChangedAnimatableProperties for the new location of letterSpacing storage.
Sam Weinig
Pull request: https://github.com/WebKit/WebKit/pull/55493
Sam Weinig
My guess was wrong. The real issue was that we weren't synchronizing letter-spacing (and word-spacing for that matter) to the FontCascade during updates made from animation code (since the interpolation functions call RenderStyle::setFoo directly, and don't have the lazy font dirtying logic of Style::BuilderState).
There was also a related issue when animating font-size of an element with percentage letter-spacing or word-spacing not re-synchronizing.
EWS
Committed 304575@main (3a3971d9fc92): <https://commits.webkit.org/304575@main>
Reviewed commits have been landed. Closing PR #55493 and removing active labels.
Ahmad Saleem
*** Bug 306261 has been marked as a duplicate of this bug. ***