Bug 304156
| Summary: | Fix `column-rule-width` parsing and remove old border style rules | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | koivisto, taher_ali, webkit-bug-importer |
| Priority: | P2 | Keywords: | BrowserCompat, EasyFix, GoodFirstBug, InRadar, WPTImpact |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team
While looking into browser specific failures, I noticed that we fail following WPT:
WPT Test Case: https://wpt.fyi/results/css/css-multicol/parsing/column-rule-width-computed.html?label=master&label=experimental&aligned&q=column-rule-width
WPT Test Case Live Link: http://wpt.live/css/css-multicol/parsing/column-rule-width-computed.html
I already synced WPT here - https://github.com/WebKit/WebKit/pull/55348
Failing sub-test - column-rule-width is as specified when column-rule-style is none or hidden
____
WebKit Source: https://github.com/WebKit/WebKit/blob/0a7cb8948b067fa78de53b601b94552e112c7ca2/Source/WebCore/rendering/style/StyleMultiColData.cpp#L90
```
Style::LineWidth StyleMultiColData::columnRuleWidth() const
{
if (columnRule.style() == BorderStyle::None || columnRule.style() == BorderStyle::Hidden)
return Style::LineWidth { 0_css_px };
return columnRule.width();
}
```
Changing it to:
```
Style::LineWidth StyleMultiColData::columnRuleWidth() const
{
return columnRule.width();
}
```
It fixes the test case.
Just raising, so we can fix it.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/166996498>
Ahmad Saleem
*** This bug has been marked as a duplicate of bug 304940 ***