Summary: | Need to turn off notifications properly at runtime | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrew Wilson <atwilson> | ||||||||||
Component: | WebCore JavaScript | Assignee: | John Gregg <johnnyg> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | commit-queue, eric | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | PC | ||||||||||||
OS: | OS X 10.5 | ||||||||||||
Attachments: |
|
Description
Andrew Wilson
2009-10-15 15:03:55 PDT
Created attachment 41529 [details]
patch
Patch adds support for the [EnabledAtRuntime] flag on DOMWindow.webkitNotifications and WorkerContext.webkitNotifications.
After I switch chromium over to using this instead of Settings, I'll remove notifications from Settings in a second patch.
I'm not sure if this is a two-sided patch needing special commit, or if this can be added to the commit-queue. I already had atwilson commit this for me: http://trac.webkit.org/changeset/49893 So the bug should have been closed. :) And now there's an even newer way of doing this. Created attachment 41750 [details]
new patch for the new way
Comment on attachment 41750 [details]
new patch for the new way
d'oh forgot the r? last week. now the patch is too out of date... will merge and resubmit.
Created attachment 42219 [details]
new patch for the new way
resynced and recreated the patch.
Comment on attachment 42219 [details] new patch for the new way > Index: WebCore/bindings/v8/RuntimeEnabledFeatures.h > + static bool isNotificationsEnabled; Hmmm, this should have been m_ since these are class members but I see you're following a pattern. > Index: WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp > + return WebCore::RuntimeEnabledFeatures::notificationsEnabled(); Since the code is in namespace WebCore, WebCore:: isn't needed. > Index: WebCore/bindings/v8/custom/V8WorkerContextCustom.cpp > + return WebCore::RuntimeEnabledFeatures::notificationsEnabled(); Since the code is in namespace WebCore, WebCore:: isn't needed. Just remove the WebCore:: from the two places mentioned on landing. Created attachment 42221 [details]
patch w/levin's feedback
removing unnecessary WebCore::'s
Comment on attachment 42221 [details] patch w/levin's feedback Clearing flags on attachment: 42221 Committed r50348: <http://trac.webkit.org/changeset/50348> All reviewed patches have been landed. Closing bug. |