Bug 303985
| Summary: | [GStreamer][WebRTC] A few uninitialized variables were added in 304213@main | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Nikolas Zimmermann <zimmermann> |
| Component: | Media | Assignee: | Philippe Normand <philn> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | philn, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Nikolas Zimmermann
In the new code added in 304213@main there are computations like `m_totalAudioEnergy += m_audioLevel * m_audioLevel * duration`, but `m_audioLevel` is only computed if we take the `if (auto audioLevelMeta = gst_buffer_get_audio_level_meta(buffer)) {` branch. Therefore m_audioLevel & co might be uninitialized - same for video tracks. All variables should always be initialized in any case.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Philippe Normand
Pull request: https://github.com/WebKit/WebKit/pull/55252
EWS
Committed 304348@main (1bf55563fd9c): <https://commits.webkit.org/304348@main>
Reviewed commits have been landed. Closing PR #55252 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/166368376>