Bug 303911
| Summary: | [WPEPlatform] Avoid null XKB context usage due to missing directories | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | WPE WebKit | Assignee: | Adrian Perez <aperez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Adrian Perez
The xkb_context_new() function may return NULL if the default include directories for configuration files cannot be found.
Instead, we can pass the XKB_CONTEXT_NO_DEFAULT_INCLUDES, and manually call xkb_context_include_path_append_default(),
which itself may fail, but then we can let libxkbcommon log the error and keep using a valid context that may not be completely
configured, but at least WebKit won't crash due to usage of a null xkb_context instances.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrian Perez
Pull request: https://github.com/WebKit/WebKit/pull/55164
EWS
Committed 304260@main (17a6481aedb0): <https://commits.webkit.org/304260@main>
Reviewed commits have been landed. Closing PR #55164 and removing active labels.