Bug 303864
| Summary: | REGRESSION(303017@main): Broke running --site-isolation with --iOS-simulator locally | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Robert Jenner <jenner> |
| Component: | Tools / Tests | Assignee: | Robert Jenner <jenner> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bot-watchers-bugzilla, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Robert Jenner
When I brought up the iOS-Site-Isolation bots in our OpenSource infrastructure, I inadvertently broke the ability to run that testing locally, hitting the following error:
AttributeError raised: 'NoneType' object has no attribute '_scm'
Traceback (most recent call last):
File "/Volumes/Data/OpenSource/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 93, in main
run_details = run(port, options, args, stderr)
File "/Volumes/Data/OpenSource/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 574, in run
_set_up_derived_options(port, options)
File "/Volumes/Data/OpenSource/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 505, in _set_up_derived_options
port.host.scm().checkout_root
File "/Volumes/Data/OpenSource/Tools/Scripts/webkitpy/common/host.py", line 97, in scm
return self._checkout._scm
AttributeError: 'NoneType' object has no attribute '_scm'
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/166160572>
Robert Jenner
Pull request: https://github.com/WebKit/WebKit/pull/55118
Robert Jenner
Pull request: https://github.com/WebKit/WebKit/pull/55143
EWS
Committed 304194@main (f6a83eece30c): <https://commits.webkit.org/304194@main>
Reviewed commits have been landed. Closing PR #55143 and removing active labels.