Bug 303792
| Summary: | css/background-origin/ tests are not seen by run-webkit-tests | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Karl Dubost <karlcow> |
| Component: | Tools / Tests | Assignee: | Sam Sneddon [:gsnedders] <gsnedders> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap, gsnedders, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Karl Dubost
When trying to run the tests script on a folder, the tests are not found, even if they are here.
Maybe it's happening for some other folders.
(Bug discovered by Joanne)
```
% run-webkit-tests --no-build imported/w3c/web-platform-tests/css/css-backgrounds/background-origin/origin-border-box_with_radius.html
[…]
Found 0 tests; running 0, skipping 0.
All tests skipped.
```
or
```
% run-webkit-tests --no-build imported/w3c/web-platform-tests/css/css-backgrounds/background-origin/
[…]
Found 0 tests; running 0, skipping 0.
All tests skipped.
```
```
% ls -1 LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-origin
origin-border-box_with_position-expected.html
origin-border-box_with_position.html
origin-border-box_with_radius-expected.html
origin-border-box_with_radius.html
origin-border-box_with_size-expected.html
origin-border-box_with_size.html
origin-border-box-expected.html
origin-border-box.html
origin-content-box_with_position-expected.html
origin-content-box_with_position.html
origin-content-box_with_radius-expected.html
origin-content-box_with_radius.html
origin-content-box_with_size-expected.html
origin-content-box_with_size.html
origin-content-box-expected.html
origin-content-box.html
origin-padding-box_with_position-expected.html
origin-padding-box_with_position.html
origin-padding-box_with_radius-expected.html
origin-padding-box_with_radius.html
origin-padding-box_with_size-expected.html
origin-padding-box_with_size.html
origin-padding-box-expected.html
origin-padding-box.html
support
w3c-import.log
```
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Karl Dubost
Alexey was wondering if the issue was created by
https://github.com/WebKit/WebKit/commit/70ff75704e53e2947b598287b894ae6a6b3b1caa
Radar WebKit Bug Importer
<rdar://problem/166101995>
Alexey Proskuryakov
Reproduces with 301409@main reverted, as well.
Sam Sneddon [:gsnedders]
Looking at `imported/w3c/web-platform-tests/css/css-backgrounds/background-origin/origin-border-box_with_radius.html` specifically:
It was originally imported in https://github.com/WebKit/WebKit/commit/8bc8dbb216de5e1156baa248abc4b219383f265e, which also added it to `LayoutTests/imported/w3c/resources/resource-files.json` (and any file listed in that JSON file is considered a resource file and not a test).
Then https://github.com/WebKit/WebKit/commit/1d17a36423416c2aac970aea382939dbe53994fa re-imported it, which also changed it from a visual test to a reftest (which means we could actually run it!), but didn't remove it from `resource-files.json`.
An obvious first question to investigate is "does the importer ever remove things from `resource-files.json`?".
Karl Dubost
@sam is there a way to know automatically if the file is a reftest or a visual test?
Sam Sneddon [:gsnedders]
Pull request: https://github.com/WebKit/WebKit/pull/55657
EWS
Committed 305533@main (aafee1bd8c1d): <https://commits.webkit.org/305533@main>
Reviewed commits have been landed. Closing PR #55657 and removing active labels.