Bug 30364

Summary: GtkLauncher is using a deprecated signal
Product: WebKit Reporter: José Millán Soto <jmillan>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, jmillan, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
GtkLauncher patch jmalonzo: review+, commit-queue: commit-queue-

Description José Millán Soto 2009-10-14 11:30:21 PDT 
GtkLauncher is using title-changed signal, which is deprecated ( http://webkitgtk.org/reference/index-deprecated.html ).
Comment 1 José Millán Soto 2009-10-14 11:36:09 PDT 
Created attachment 41174 [details]
GtkLauncher patch

This patch changes the signal which GtkLoader uses to follow the page's title from title-changed to notify::title.
It also makes GtkLoader not affected by bug #19843.
Comment 2 José Millán Soto 2009-10-14 13:26:46 PDT 
Ups, GtkLauncher, not GtkLoader
Comment 3 Jan Alonzo 2009-10-14 15:03:10 PDT 
Comment on attachment 41174 [details]
GtkLauncher patch

r=me.
Comment 4 WebKit Commit Bot 2009-10-14 15:16:45 PDT 
Comment on attachment 41174 [details]
GtkLauncher patch

Rejecting patch 41174 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11436 test cases.
fast/css/opacity-float.html -> failed

Exiting early after 1 failures. 5146 tests run.
238.99s total testing time

5145 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
1 test case (<1%) had stderr output
Comment 5 Xan Lopez 2009-10-15 00:36:52 PDT 
Pushed this manually, r49611.
Comment 6 Eric Seidel (no email) 2009-10-15 10:04:37 PDT 
It looks like this was a false rejection due to bug 30098.  My apologies.