Bug 303627
| Summary: | Web Inspector: Pull CSS property keyword completions from the backend instead of hardcoding them | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brandon <brandonstewart> |
| Component: | Web Inspector | Assignee: | Brandon <brandonstewart> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | inspector-bugzilla-changes, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Brandon
CSSKeywordCompletions.js contained hardcoded lists of valid keyword values for CSS properties like `display`.
The backend already provides keyword values for properties that are "keyword-fast-path eligible" via getSupportedCSSProperties(). However, properties like `display` that use custom parsers weren't included.
This patch adds a new generated function CSSProperty::validKeywordsForProperty() that returns the valid keyword values from CSSProperties.json.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/165914089>
Brandon
Pull request: https://github.com/WebKit/WebKit/pull/54923
EWS
Committed 304195@main (68e73e36fe06): <https://commits.webkit.org/304195@main>
Reviewed commits have been landed. Closing PR #54923 and removing active labels.