Bug 30357 – [Qt] Be able to specify a header and footer when printing from WebKit

• Component: WebKit Qt
• Status: RESOLVED INVALID

Be able to specify a header and footer when printing from WebKit, this has been requested from a Qt user.  Currently they have to render it separately so that the header and footer can be included afterwards when actually printing it.

This was requested against Qt 4.5.3 (not sure if the WebKit version matches up or not).

[Brent Fulgham]

Doesn't the WebUIDelegate provide the ability to specify the header/footer behavior?

[Diego Gonzalez]

Created attachment 77234 [details]
no customizable way

[Diego Gonzalez]

Created attachment 77691 [details]
Patch

[Ariya Hidayat]

Comment on attachment 77691 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77691&action=review

r-, in particular because the merging with 26584 needs to be planned

> WebKit/qt/Api/qwebframe.cpp:1431
> +QWebPrinter* QWebFrame::webPrinter()
> +{
> +    static QWebPrinter* p = 0;
> +    if (!p)
> +       p = new QWebPrinter;
> +
> +    return p;
> +}

This will leak memory.

> WebKit/qt/Api/qwebframe.h:131
> +class QWEBKIT_EXPORT QWebPrinter {
> +public:
> +    bool printHeaderAndFooter() const { return hasHeaderAndFooter; }
> +    void setPrintHeaderAndFooter(bool flag = true) { hasHeaderAndFooter = flag; }
> +
> +    void setHeader(const QString& left, const QString& center, const QString& right);
> +    void setFooter(const QString& left, const QString& center, const QString& right);
> +
> +private:
> +    QWebPrinter()
> +        : hasHeaderAndFooter(false)
> +    {}
> +
> +    QString headerLeft;
> +    QString headerCenter;
> +    QString headerRight;
> +    QString footerLeft;
> +    QString footerCenter;
> +    QString footerRight;
> +
> +    bool hasHeaderAndFooter;
> +
> +    friend class QWebFrame;
> +};
> +#endif

This is a whole new set of API. Needs some coordinated discussion.

For example, this should be merged to Bug 26584.

[Diego Gonzalez]

Sure Ariya, I will take at bug 26584 to discuss this merge :)

(In reply to comment #4)
> (From update of attachment 77691 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=77691&action=review
> 
> r-, in particular because the merging with 26584 needs to be planned
> 
> > WebKit/qt/Api/qwebframe.cpp:1431
> > +QWebPrinter* QWebFrame::webPrinter()
> > +{
> > +    static QWebPrinter* p = 0;
> > +    if (!p)
> > +       p = new QWebPrinter;
> > +
> > +    return p;
> > +}
> 
> This will leak memory.
> 
> > WebKit/qt/Api/qwebframe.h:131
> > +class QWEBKIT_EXPORT QWebPrinter {
> > +public:
> > +    bool printHeaderAndFooter() const { return hasHeaderAndFooter; }
> > +    void setPrintHeaderAndFooter(bool flag = true) { hasHeaderAndFooter = flag; }
> > +
> > +    void setHeader(const QString& left, const QString& center, const QString& right);
> > +    void setFooter(const QString& left, const QString& center, const QString& right);
> > +
> > +private:
> > +    QWebPrinter()
> > +        : hasHeaderAndFooter(false)
> > +    {}
> > +
> > +    QString headerLeft;
> > +    QString headerCenter;
> > +    QString headerRight;
> > +    QString footerLeft;
> > +    QString footerCenter;
> > +    QString footerRight;
> > +
> > +    bool hasHeaderAndFooter;
> > +
> > +    friend class QWebFrame;
> > +};
> > +#endif
> 
> This is a whole new set of API. Needs some coordinated discussion.
> 
> For example, this should be merged to Bug 26584.

[Jocelyn Turcotte]

=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.