Bug 303519

Summary:	Update MetaAllocator::freeFreeSpaceNode() to call the FreeSpaceNode destructor
Product:	WebKit	Reporter:	Chris Dumez <cdumez>
Component:	Web Template Framework	Assignee:	Chris Dumez <cdumez>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	ddkilzer, ggaren, webkit-bug-importer, ysuzuki
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Chris Dumez

Reported 2025-12-03 21:29:44 PST

Update MetaAllocator::freeFreeSpaceNode() to call the FreeSpaceNode destructor before freeing it. It is not correct to free a non-POD object before first running its destructor in C++. This can lead to bugs and leaks. This is particularly important now that FreeSpaceNode now subclasses CanMakeThreadSafeCheckedPtr.

Attachments
Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2025-12-03 21:31:37 PST

Pull request: https://github.com/WebKit/WebKit/pull/54816

EWS

Comment 2 2025-12-06 05:49:07 PST

Committed 304051@main (98aa585d7ea2): <https://commits.webkit.org/304051@main> Reviewed commits have been landed. Closing PR #54816 and removing active labels.

Radar WebKit Bug Importer

Comment 3 2025-12-06 05:50:12 PST

<rdar://problem/165975763>

Note You need to log in before you can comment on or make changes to this bug.