Bug 30348 – Implement private mode for plug-ins on Windows

• Component: Plug-ins
• Status: RESOLVED FIXED

[Brian Weinstein]

plugins/private-browsing-mode.html fails on Windows, as the private plugin mode is only implemented on Mac. I am going to add it to the Skipped list, and this bug is to track the implementing of the mode on Windows.

[Jon Honeycutt]

<rdar://problem/7562261>

[Mark Rowe (bdash)]

Created attachment 49796 [details]
Implement the “get” side of NPNVprivateModeBool

This is mainly refactoring to remove the duplication within PluginView::getValue.  A side-effect of this is that Windows gains the implementation of getValue for NPNVprivateModeBool that Qt recently added.

A later patch will need to handle notifying plug-ins when the value for NPNVprivateModeBool changes.

[WebKit Review Bot]

Attachment 49796 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/plugins/PluginView.cpp:1325:  Missing space before ( in switch(  [whitespace/parens] [5]
WebCore/plugins/win/PluginViewWin.cpp:60:  "PluginPackage.h" already included at WebCore/plugins/win/PluginViewWin.cpp:59  [build/include] [4]
WebCore/plugins/win/PluginViewWin.cpp:886:  Declaration has space between type name and * in NPBool *flag  [whitespace/declaration] [3]
Total errors found: 3 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Mark Rowe (bdash)]

Created attachment 49798 [details]
Updated patch

May as well fix those existing style issues while I’m touching the code.

[WebKit Review Bot]

Attachment 49798 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/plugins/PluginView.cpp:1325:  Missing space before ( in switch(  [whitespace/parens] [5]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Mark Rowe (bdash)]

I filed bug 35576 to track the other half of this: notifying a plug-in instance when the private browsing state changes.

[WebKit Review Bot]

Attachment 49798 [details] did not build on gtk:
Build output: http://webkit-commit-queue.appspot.com/results/320767

[Mark Rowe (bdash)]

Created attachment 49801 [details]
Updated patch

Switch to using “default" to prevent warnings about unhandled enum values in switches.

[WebKit Review Bot]

Attachment 49801 [details] did not build on gtk:
Build output: http://webkit-commit-queue.appspot.com/results/320780

[Oliver Hunt]

Comment on attachment 49801 [details]
Updated patch

r=me

[Mark Rowe (bdash)]

Landed in r55432.

[Ismail Donmez]

This broke compilation with Qt/Linux with plugins disabled:

PluginView.h protects getValueStatic(..) function with 

#if ENABLE(NETSCAPE_PLUGIN_API)

but it does not do so in PluginView.cpp. There are some other compilation problems related to this commit as well but they'll need to be handled in seperate bugs.