Bug 303430
| Summary: | [Filters] Add GraphicsContextFiltersEnabled preference back as a stable feature | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> |
| Component: | Layout and Rendering | Assignee: | Said Abou-Hallawa <sabouhallawa> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=292602 https://bugs.webkit.org/show_bug.cgi?id=298544 https://bugs.webkit.org/show_bug.cgi?id=302900 https://bugs.webkit.org/show_bug.cgi?id=295424 |
||
Said Abou-Hallawa
This feature flag was removed in 294623@main. It was added back in 297006@main but as a mature feature. This made it checkable in the code but invisible in the UI. A separate feature flag was added later for GaussianBlur filter in 299740@main. This feature flag is still stable so it allows turning the CG GaussianBlur filter from the UI. Some bugs were reported recently related to non GaussianBlur file like bug 302900. Having GraphicsContextFiltersEnabled visible in the UI, would have made it easier to confirm whether these bugs are related to CoreGraphics filter or not. Also having a separate feature flag for GaussianBlur filter made the code a little bit complicated.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/165725017>
Said Abou-Hallawa
Pull request: https://github.com/WebKit/WebKit/pull/54732
EWS
Committed 303819@main (42277eece690): <https://commits.webkit.org/303819@main>
Reviewed commits have been landed. Closing PR #54732 and removing active labels.