Bug 303356
| Summary: | [RenderStyleGen] Generate getter/setter function declarations | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> |
| Component: | CSS | Assignee: | Diego Pino <dpino> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dpino, koivisto, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari 18 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Sam Weinig
Extend generation to also generate the function declarations.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sam Weinig
Pull request: https://github.com/WebKit/WebKit/pull/54673
Sam Weinig
Pull request: https://github.com/WebKit/WebKit/pull/54847
EWS
Committed 304026@main (b7a21d91ed79): <https://commits.webkit.org/304026@main>
Reviewed commits have been landed. Closing PR #54847 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/165948558>
Diego Pino
There was a build error on 'GTK-Linux-64-bit-Release-Debian-Stable-Build' after this patch:
https://build.webkit.org/#/builders/46/builds/58225
```
WebCore/PrivateHeaders/WebCore/RenderStyleInlines.h: In member function ‘constexpr bool WebCore::RenderStyle::isOriginalDisplayBlockType() const’:
WebCore/PrivateHeaders/WebCore/RenderStyleInlines.h:544:107: error: call to non-‘constexpr’ function ‘WebCore::DisplayType WebCore::RenderStyleBase::originalDisplay() const’
544 | constexpr bool RenderStyle::isOriginalDisplayBlockType() const { return isDisplayBlockType(originalDisplay()); }
| ~~~~~~~~~~~~~~~^~
```
Diego Pino
Re-opening for pull request https://github.com/WebKit/WebKit/pull/55029
EWS
Committed 304089@main (272c250b6663): <https://commits.webkit.org/304089@main>
Reviewed commits have been landed. Closing PR #55029 and removing active labels.