Summary: | [Qt] Fix build break for Qt 4.4 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fumitoshi Ukai <ukai> | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, eric, kenneth, laszlo.gombos, webkit.review.bot | ||||
Priority: | P2 | Keywords: | Qt | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Fumitoshi Ukai
2009-10-13 01:19:44 PDT
Created attachment 45560 [details]
proposed patch
Enables building (on Linux requires to turn off NPAPI support) with Qt 4.4.
I think we should keep the 4.4 support around in the trunk for a while. 4.4.3 was released in 28 September 2008, which was not that long ago and at the moment it does not seems like a big effort to maintain most QtWebKit features for Qt 4.4 as well.
style-queue ran check-webkit-style on attachment 45560 [details] without any errors.
Comment on attachment 45560 [details]
proposed patch
In general, you can land build fixes without review.
Comment on attachment 45560 [details] proposed patch Clearing flags on attachment: 45560 Committed r52601: <http://trac.webkit.org/changeset/52601> All reviewed patches have been landed. Closing bug. Why are we doing patches for supporting 4.4 which we decided to not support anymore? I didn't realize (and I would assume Fumitoshi didn't realize) that we were not supporting GCC 4.4. Do we have a webkit-dev thread on the subject I should (re-)read? Oh, sorry, I was confused. This is Qt 4.4. Not GCC 4.4. My retract my previous comment. |