Bug 303173
| Summary: | [GTK] Use WebKitImage for the GTK snapshot implementation | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Pena <spena> |
| Component: | WebKitGTK | Assignee: | Diego Pino <dpino> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, dpino |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Simon Pena
Rather than having separate implementations between WPE and GTK, this uses WebKitImage for both, converting to GdkTexture when appropriate (and still falling back to cairo_surface_t when 2022_GLIB_API is not enabled).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Simon Pena
Pull request: https://github.com/WebKit/WebKit/pull/54515
EWS
Committed 304209@main (4f90f08efe55): <https://commits.webkit.org/304209@main>
Reviewed commits have been landed. Closing PR #54515 and removing active labels.
Diego Pino
I think this PR broke the build with GTK3:
https://build.webkit.org/#/builders/1519/builds/8848
```
../../../Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:5202:40: error: ‘class WebCore::ShareableBitmap’ has no member named ‘createCairoSurface’
5202 | auto surface = bitmap->createCairoSurface();
| ^~~~~~~~~~~~~~~~~~
```
Diego Pino
Re-opening for pull request https://github.com/WebKit/WebKit/pull/55189
EWS
Committed 304280@main (15ddceed95e1): <https://commits.webkit.org/304280@main>
Reviewed commits have been landed. Closing PR #55189 and removing active labels.