Bug 303088 – [WKCI] Make WPE-Cairo bot build with LibWebRTC

• Component: New Bugs
• Status: RESOLVED FIXED

[Diego Pino]

Changeset 300680@main, added a new build flag in the configuration of builder 'wpe-cairo' to make it build with LibWebRTC. Although this change became effective, the EWS 'wpe-cairo' builder is not yet building with LibWebRTC. This can be verified in one of the many builds for that bot:

https://ews-build.webkit.org/#/builders/65/builds/83496/steps/16/logs/stdio

```
perl Tools/Scripts/build-webkit --release --wpe
 in dir /home/buildbot-worker/WPE-Cairo-Build-EWS/build (timeout 3600 secs)
 watching logfiles {}
 argv: [b'perl', b'Tools/Scripts/build-webkit', b'--release', b'--wpe']
 using PTY: False
```

Step **compile-webkit** is not passing the arguments set in 'additionalArguments' for that bot (https://github.com/WebKit/WebKit/blob/main/Tools/CISupport/ews-build/config.json#L421).

After researching this issue, I found out that since 263387@main, 'additionalArguments' also need to be added to a builder factory in order to become effective. This requirement only applies to EWS factories and not post-commit factories.

Since we're switching the 'wpe-cairo' bot to build with LibWebRTC, probably we would also like to reflect that on its 'shortname' property ('wpe-cairo-webrtc').

[Diego Pino]

Pull request: https://github.com/WebKit/WebKit/pull/54442

[EWS]

Committed 303565@main (084d2466a8fe): <https://commits.webkit.org/303565@main>

Reviewed commits have been landed. Closing PR #54442 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/165436972>

[Diego Pino]

*** Bug 299726 has been marked as a duplicate of this bug. ***